[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap





On 7/29/19 8:33 AM, Andrii Anisov wrote:
Hello Julien,

On 26.07.19 17:02, Julien Grall wrote:
Hi,

It looks like the vmap solution suggested by Andrew & I is a dead end. I still think we need to do something in the vmap regardless the alignment decision to avoid unwanted surprised (i.e the Page-table not in sync with the vmap state).

We potentially want to add some ASSERT_UNREACHABLE() in the page-table code for the sanity check. So we don't continue without further on debug build. I will have a look at both.

A couple of comments for the patch.

Title: NIT: Missing space after the first :.

On 18/07/2019 14:22, Andrii Anisov wrote:
From: Andrii Anisov <andrii_anisov@xxxxxxxx>

After changes introduced by 9cc0618 we are able to vmap/vunmap

7-digit is not sufficient to guarantee it will be uniq in the future. You also want to specify the commit title.

page aligned addresses only.
So if we add a page address remainder to the mapped virtual address,
we have to mask it out before unmapping.

Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

Acked-by: Julien Grall <julien.gralL@xxxxxxx>


If you are happy with the changes, I can do them on commit.

It's fine with me.
Thank you.

Now committed.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.