Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

It looks like the vmap solution suggested by Andrew & I is a dead end. I still 
think we need to do something in the vmap regardless the alignment decision to 
avoid unwanted surprised (i.e the Page-table not in sync with the vmap state).
We potentially want to add some ASSERT_UNREACHABLE() in the page-table code for 
the sanity check. So we don't continue without further on debug build. I will 
have a look at both.
A couple of comments for the patch.

Title: NIT: Missing space after the first :.

On 18/07/2019 14:22, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@xxxxxxxx>
>
> After changes introduced by 9cc0618 we are able to vmap/vunmap
7-digit is not sufficient to guarantee it will be uniq in the future. You also 
want to specify the commit title.
> page aligned addresses only.
> So if we add a page address remainder to the mapped virtual address,
> we have to mask it out before unmapping.
>
> Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
Acked-by: Julien Grall <julien.gralL@xxxxxxx>


If you are happy with the changes, I can do them on commit.

> ---
>   xen/arch/arm/cpuerrata.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
> index 8904939..6f483b2 100644
> --- a/xen/arch/arm/cpuerrata.c
> +++ b/xen/arch/arm/cpuerrata.c
> @@ -75,7 +75,7 @@ static bool copy_hyp_vect_bpi(unsigned int slot, const char 
> *hyp_vec_start,
>       clean_dcache_va_range(dst_remapped, VECTOR_TABLE_SIZE);
>       invalidate_icache();
>   
> -    vunmap(dst_remapped);
> +    vunmap((void *)((vaddr_t)dst_remapped & PAGE_MASK));
>   
>       return true;
>   }
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel