Re: [Xen-devel] [PATCH v3 13/13] print: introduce a format specifier for pci_sbdf_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.19 at 17:12, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 17/06/2019 16:10, Jan Beulich wrote:
>>>>> On 07.06.19 at 11:22, <roger.pau@xxxxxxxxxx> wrote:
>>> The new format specifier is '%pp', and prints a pci_sbdf_t using the
>>> seg:bus:dev.func format. Replace all SBDFs printed using
>>> '%04x:%02x:%02x.%u' to use the new format specifier.
>> Well, I continue to not be happy about the use of %p (rather than the
>> proposed %o) here. I don't suppose you've actually tried, and it didn't
>> work out?
> 
> You can't use %o for reasons I've already demonstrated multiple times
> already for your previous requests.
> 
> Neither GCC nor Clang tolerate it with -Wformat.

You've said so before without proof, simply by extending from proposals
I had made for %p which indeed you were right would not be tolerated
with -Wformat. I can only state again: I cannot see why compilers would
be unhappy about a 32-bit int getting passed for a %o format specifier.

And by going this route we'd avoid a future clash with whatever meaning
Linux may assign to %pp. Granted this a minor aspect, as I don't think
we should slavishly follow Linux'es extensions, but anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel