Re: [Xen-devel] [PATCH] xen: make tracebuffer configurable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.06.19 at 16:08, <George.Dunlap@xxxxxxxxxx> wrote:

> 
>> On Jun 3, 2019, at 11:54 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> 
>>>>> On 03.06.19 at 12:41, <chenbaodong@xxxxxxxxxx> wrote:
>> 
>>> On 6/3/19 16:31, Jan Beulich wrote:
>>>>>>> On 03.06.19 at 05:07, <chenbaodong@xxxxxxxxxx> wrote:
>>>>> On 5/31/19 19:10, Jan Beulich wrote:
>>>>>>>>> On 30.05.19 at 12:17, <chenbaodong@xxxxxxxxxx> wrote:
>>>>>>> Default: enabled.
>>>>>>> Can be disabled for smaller code footprint.
>>>>>> But you're aware that we're, for now at least, trying to limit the
>>>>>> number of independently selectable config options? Ones depending
>>>>>> on EXPERT are sort of an exception in certain cases.
>>>>> Limit the number of independently selectable config sounds good to me.
>>>>> 
>>>>> Does the following looks good?
>>>>> 
>>>>> +config HAS_TRACEBUFFER
>>>>> +       bool "Enable/Disable tracebuffer"  if EXPERT = "y"
>>>>> +       ---help---
>>>>> +         Enable or disable tracebuffer function.
>>>>> +         Xen internal running status(trace event) will be saved to
>>>>> trace memory
>>>>> +         when enabled.
>>>>> +
>>>> The EXPERT addition make introducing this fine by me. But its name
>>>> is still wrong, and the help text also needs further improvement imo.
>>> 
>>> Hi Jan, thanks for your kindly review and feedback.
>>> 
>>> For this, would you please give your suggestions about the name and help 
>>> text?
>> 
>> As far as the name is concerned, the HAS_ should be dropped.
>> I'm afraid I don't have a particular suggestion for the help text.
> 
> You could at least give an idea what you think the help text should include, 
> or some kind of guidance as to what would satisfy you.  Obviously you 
> shouldn’t be required to write everybody’s help text for them; but by the 
> same token, everybody shouldn’t be required to read your mind.
> 
> Is, “A description of the feature, along with the costs of enabling it” the 
> sort of thing you had in mind?

I had nothing in particular in mind. There ought to be other Kconfig
options with at least half way reasonable help text, which I think
could be used as guidance. Beyond that I think help text largely only
re-stating what the prompt already says isn't helpful, and hence
could as well be omitted.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel