Re: [Xen-devel] [PATCH] xen: make tracebuffer configurable

[chenbaodong <chenbaodong@xxxxxxxxxx>]

On 6/3/19 16:31, Jan Beulich wrote:
> > > > On 03.06.19 at 05:07, <chenbaodong@xxxxxxxxxx> wrote:
> > On 5/31/19 19:10, Jan Beulich wrote:
> > > > > > On 30.05.19 at 12:17, <chenbaodong@xxxxxxxxxx> wrote:
> > > > Default: enabled.
> > > > Can be disabled for smaller code footprint.
> > > But you're aware that we're, for now at least, trying to limit the
> > > number of independently selectable config options? Ones depending
> > > on EXPERT are sort of an exception in certain cases.
> > Limit the number of independently selectable config sounds good to me.
> >
> > Does the following looks good?
> >
> > +config HAS_TRACEBUFFER
> > +       bool "Enable/Disable tracebuffer"  if EXPERT = "y"
> > +       ---help---
> > +         Enable or disable tracebuffer function.
> > +         Xen internal running status(trace event) will be saved to
> > trace memory
> > +         when enabled.
> > +
> The EXPERT addition make introducing this fine by me. But its name
> is still wrong, and the help text also needs further improvement imo.
Hi Jan, thanks for your kindly review and feedback.

For this, would you please give your suggestions about the name and help 
text?
> Jan
>
>
> .
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel