Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.03.19 at 11:23, <julien.grall@xxxxxxx> wrote:
> On 3/12/19 9:35 AM, Jan Beulich wrote:
>>>>> On 11.03.19 at 19:19, <julien.grall@xxxxxxx> wrote:
>>> On 11/03/2019 16:52, Jan Beulich wrote:
>>>> Correct coding style of asm() invocations.
>>> Coding style from where? Most of the Arm code does not contain space before 
>>> and after ) for asm invocations. I also can't find anywhere in CODING_STYLE
>>> imposing this style. So please remove this change.
>> 
>> "asm" is a keyword just like "if" or "while", so the general "White space"
>> section is as applicable here. I can split the change if this part is
>> controversial, but if you want me to drop the change, then an Arm
>> specific annex to ./CODING_STYLE is going to be needed.
> 
> Strictly speaking, the section you refer mentions space between 
> "keywords" and "conditions". So I don't feel the section applies for 
> "asm volatile".

Well, if you take it to the word then it wouldn't be applicable to
for(;;) either, and perhaps also not to switch(). To me this
paragraph talks about (control) keywords in general that are
followed by what one may call "operands" in parentheses.

> For Arm, I would still prefer to keep without space as we have most of 
> the code following that.

Well, as said - I'll split the patch then, but I'll refrain from re-
submitting the asm() part only if an Arm specific amendment to
the style guide appears. Otherwise Arm code should imo be
brought in sync with what we (try to) consistently do in x86
and common code. And of course such bringing in sync can
happen over time, as code gets touched anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel