Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.03.19 at 19:19, <julien.grall@xxxxxxx> wrote:
> On 11/03/2019 16:52, Jan Beulich wrote:
>> Correct coding style of asm() invocations.
> Coding style from where? Most of the Arm code does not contain space before ( 
> and after ) for asm invocations. I also can't find anywhere in CODING_STYLE 
> imposing this style. So please remove this change.

"asm" is a keyword just like "if" or "while", so the general "White space"
section is as applicable here. I can split the change if this part is
controversial, but if you want me to drop the change, then an Arm
specific annex to ./CODING_STYLE is going to be needed.

Jan

>>  Drop redundant casts.
>> Un-define no longer needed macros after use.
> 
> I am happy with the those two changes.
> 
> Cheers,
> 
> -- 
> Julien Grall





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel