[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] RT Xen on ARM - R-Car series


On Fri, Feb 15, 2019 at 4:23 PM Andrii Anisov <andrii.anisov@xxxxxxxxx> wrote:
> On 14.02.19 18:29, Roger Pau Monné wrote:
> > In order to simplify stuff the new interface could require runstate
> > areas to be page aligned, but I think the check can be relaxed to
> > simply require runstate areas to not cross a page boundary.
> My idea so far is to keep the same `struct vcpu_runstate_info` but harden it 
> with `__attribute__((aligned(64)))` right in the interface file vcpu.h. Also 
> add some guard asserts verifying that its actual size is less than 64 bytes.

Why? Is it because you want to be cache-aligned?  If so, requiring the
structure to be 64-bytes is not enough. You also want the address to
be 64-bytes aligned.
However, I am not sure why we should bother with that in the
interface.... The cacheline varies between architectures and even SoC.
If an OS cares about it, then it can aligned itself here.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.