Re: [Xen-devel] [PATCH v8] arch/x86: Add registers to vm_event

[Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>]

On 09.11.2018 13:05, Alexandru Stefan ISAILA wrote:
> 
> 
> On 08.11.2018 20:02, Wei Liu wrote:
>> On Thu, Nov 08, 2018 at 07:56:29PM +0200, Razvan Cojocaru wrote:
>>> On 11/8/18 7:22 PM, Wei Liu wrote:
>>>> On Thu, Nov 08, 2018 at 05:56:07PM +0200, Razvan Cojocaru wrote:
>>>>> On 11/8/18 5:53 PM, Wei Liu wrote:
>>>>>> On Thu, Nov 08, 2018 at 05:19:48PM +0200, Razvan Cojocaru wrote:
>>>>>>> On 11/6/18 7:16 PM, Tamas K Lengyel wrote:
>>>>>>>> On Mon, Nov 5, 2018 at 2:54 AM Alexandru Stefan ISAILA
>>>>>>>> <aisaila@xxxxxxxxxxxxxxx> wrote:
>>>>>>>>>
>>>>>>>>> This patch adds a couple of regs to the vm_event that are used by
>>>>>>>>> the introspection. The base, limit and ar
>>>>>>>>> bits are compressed into a uint64_t union so as not to enlarge the
>>>>>>>>> vm_event.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
>>>>>>>>
>>>>>>>> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>>>>>>>
>>>>>>> To the best of my ability to figure out the necessary acks, I believe
>>>>>>> that this one is ready to go in. :)
>>>>>>
>>>>>> Alright. I will pick this up in my next sweep.
>>>>>
>>>>> Thanks!
>>>>
>>>>
>>>> Unfortunately this will break shim build when HVM is disabled. Please
>>>> submit a new version. I think you will need to put
>>>> vm_event_pack_segment_register under CONFIG_HVM.
>>>
>>> Very sorry about that. We'll resubmit.
>>
>> Speaking of build breakage: would you guys consider signing up to gitlab
>> so that you can use all the build test infrastructure there before
>> submission? It would probably say you from building local for different
>> distros and configs.
>>
>> See https://gitlab.com/xen-project/xen/pipelines/35918510
>>
> 
> Hi Wei,
> 
> I've guarded the vm_event_pack_segment_register with CONFIG_HVM for the
> next version. I've run the tests on gitlab and they where all passed. I
> want to suggest if you can add some AMD tests so we can be sure that all

I wanted to say ARM not AMD, sorry

~Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel