[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce 
Xenctrl.with_intf wrapper"):
> You are right - close_handle should set the handle to None in addition.
> > For that matter, why is close_handle needed at all ?
> I mostly added it for symmetry and it is needed to set the handle to None 
> (see above) 
> because interface_close() can’t do it.

Well, yes, but who would ever call it ?  It's not safe to use except
at the toplevel (whatever that means, but probably outside any
with_intf) because elsewhere you don't know whose work you're

Which reminds me: why do you say it is wrong to use both
interface_open and with_intf ?  It's clumsy and probably a mistake but
it should function correctly I think.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.