Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

[Christian Lindig <christian.lindig@xxxxxxxxxx>]

> On 30 Oct 2018, at 16:48, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> 
> I think it would be better to have close_handle set handle to None,
> and write in the docs that it is forbidden to call close_handle within
> with_intf. 

You are right - close_handle should set the handle to None in addition.

> For that matter, why is close_handle needed at all ?

I mostly added it for symmetry and it is needed to set the handle to None (see 
above) 
because interface_close() can’t do it.

— C
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel