[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

  • To: Ian Jackson <Ian.Jackson@xxxxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Tue, 30 Oct 2018 16:54:56 +0000
  • Accept-language: en-GB, en-US
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>
  • Delivery-date: Tue, 30 Oct 2018 16:54:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHUcEH8ZsM/0EkdLUS3Ebe06iKfPqU374gAgAABwgA=
  • Thread-topic: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

> On 30 Oct 2018, at 16:48, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> I think it would be better to have close_handle set handle to None,
> and write in the docs that it is forbidden to call close_handle within
> with_intf. 

You are right - close_handle should set the handle to None in addition.

> For that matter, why is close_handle needed at all ?

I mostly added it for symmetry and it is needed to set the handle to None (see 
because interface_close() can’t do it.

— C
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.