Re: [Xen-devel] [PATCH] xen: Fix inconsistent callers of panic()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.08.18 at 09:30, <jgross@xxxxxxxx> wrote:
> On 31/08/18 09:21, Jan Beulich wrote:
>>>>> On 31.08.18 at 09:12, <jgross@xxxxxxxx> wrote:
>>> On 31/08/18 09:04, Jan Beulich wrote:
>>>>>>> On 31.08.18 at 08:43, <jgross@xxxxxxxx> wrote:
>>>>> On 31/08/18 08:33, Jan Beulich wrote:
>>>>>>>>> On 30.08.18 at 19:08, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>>>>> On 30/08/18 15:07, Jan Beulich wrote:
>>>>>>>>>>> On 30.08.18 at 14:31, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>>>>>>> The observant amongst you might realise that this reverts parts of c/s
>>>>>>>>> 51ad90aea21c - What can I say?  Several years of hindsight is very 
>>>>>>>>> useful, 
>>> and
>>>>>>>>> at the time I did ask the maintainers which option they thought would 
>>>>>>>>> be
>>>>>>>>> better...
>>>>>>>> ... I think both the earlier and this change are heading in the
>>>>>>>> wrong direction: I would much rather see the newline omitted
>>>>>>>> everywhere, _including_ in panic() itself: This causes one line
>>>>>>>> less to scroll off the screen in case you don't have a serial
>>>>>>>> console.
>>>>>
>>>>> Can't we just drop printing the extra \n in panic()?
>>>>>
>>>>> -    printk("%s\n", buf);
>>>>> +    printk("%s", buf);
>>>>
>>>> That's what I'm suggesting, yes, plus (if there are any) dropping
>>>> trailing newlines in panic() invocations.
>>>
>>> Uuh, both?
>>>
>>> This would look like:
>>>
>>> ***********************************
>>> PANIC on cpu 2:
>>> blalblabla**********************************
>> 
>> Hmm, the trailing **** would perhaps better also be dropped. As per
>> my original reply to Andrew, the goal should imo be to have as little
>> useless output as possible (but as much as necessary/helpful, i.e. I'm
>> not suggesting to drop the first line of stars), to avoid meaningful
>> lines scrolling off.
> 
> I don't think:
> 
> ***********************************
> PANIC on cpu 2:
> blalblablaReboot in five seconds...
> 
> is what we want.
> 
> So one '\n' should stay: either when printing the panic message, or in
> the panic message itself.

Oh, all these pretty useless extra lines. In that case I think Andrew's
patch is quite fine, unless we can reach agreement to drop all the
extra cruft such that the actual panic message is last on the screen.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel