Re: [Xen-devel] [PATCH] xen: Fix inconsistent callers of panic()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.08.18 at 14:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> Callers are inconsistent with whether they pass a newline to panic(),
> including adjacent calls in the same function using different styles.
> 
> painc() not expecting a newline is inconsistent with most other printing
> functions, which is most likely why we've gained so many inconsistencies.
> 
> Switch panic() to expect a newline, and update all callers which currently
> lack a newline to include one.
> 
> This actually reduces the size of .rodata (0x07e3e8 down to 0x07e3a8) because
> a number of strings are passed to both panic() and printk().  As they
> previously differed by \n alone, they couldn't be merged.

I agree this is a nice side effect, but ...

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> 
> (Restricted to the core arch maintainers as this is a tree-wide piece of
> cleanup with no functional impact to other areas.)
> 
> The observant amongst you might realise that this reverts parts of c/s
> 51ad90aea21c - What can I say?  Several years of hindsight is very useful, and
> at the time I did ask the maintainers which option they thought would be
> better...

... I think both the earlier and this change are heading in the
wrong direction: I would much rather see the newline omitted
everywhere, _including_ in panic() itself: This causes one line
less to scroll off the screen in case you don't have a serial
console.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel