Re: [Xen-devel] [PATCH 30/34] x86: PIT emulation is common to PV and HVM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> Move the common parts to emul-i8254.c. This requires moving some of
> the macros to vpt.h. Some of the code in common code is put under
> is_hvm_* checks so that DCE can kick in. Factor out HVM only
> pit_load_count_channel0 to reduce amount of code in x86 common code.
> 
> Leave HVM specific code where it was before.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/Makefile         |   1 +-
>  xen/arch/x86/emul-i8254.c     | 506 +++++++++++++++++++++++++++++++++++-
>  xen/arch/x86/hvm/i8254.c      | 462 +--------------------------------

When the file as a whole is 600 lines, I think I agree with Roger
that moving the entire file (and adding some #ifdef-ary) is
probably better, and avoids exposing internals through vpt.h.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel