Re: [Xen-devel] [PATCH 30/34] x86: PIT emulation is common to PV and HVM

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Aug 17, 2018 at 04:12:48PM +0100, Wei Liu wrote:
> Move the common parts to emul-i8254.c. This requires moving some of
> the macros to vpt.h. Some of the code in common code is put under
> is_hvm_* checks so that DCE can kick in. Factor out HVM only
> pit_load_count_channel0 to reduce amount of code in x86 common code.
> 
> Leave HVM specific code where it was before.

IMO I would rather have the whole emulation code in a single file and
the HVM only functions guarded by CONFIG_HVM. I think it's easier to
find and understand the code if it's all placed in a single file.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel