Re: [Xen-devel] Ping: [PATCH] x86/HVM: correct an inverted check in hvm_load()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Aug 16, 2018 at 02:05:02AM -0600, Jan Beulich wrote:
> >>> On 01.08.18 at 17:36,  wrote:
> > Clearly we want to put a vCPU to sleep if it is _not_ already down.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > TBD: Since the flaw apparently never mattered, I imply that the function
> >      is never called with any vCPU up. Hence an alternative might be to
> >      simply return an error if a vCPU doesn't have VPF_down set.
> 
> While in an earlier reply you've indicated that the suggested
> alternative is not an option, I've not had clear feedback on the
> change below.

This LGTM and fixes an obvious bug. I don't have an opinion on the
above or whether Colo/Remus works at all, but the fix below seems to
be less controversial than returning error.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel