Re: [Xen-devel] [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH v3 15/31] libxl_qmp_ev: Implement fd 
callback and read data"):
> On Wed, Jun 27, 2018 at 04:10:18PM +0100, Ian Jackson wrote:
> > How big is this data ?  Is all this business with a linked list of
> > buffers really necessary ?
> 
> The alternative is realloc. I don't know how big the data is going to
> be. I don't want to speculate.

Yes, but there is not anything very wrong with realloc.

> But right now, QMP_RECEIVE_BUFFER_SIZE is set to 4k, I don't think we
> would need more than that, but I think the code need to be prepared to
> receive more.

All of this buffer queue complication is a performance optimisation to
avoid hypothetical reallocs, then :-) ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel