[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data



On Wed, Jun 27, 2018 at 04:10:18PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH v3 15/31] libxl_qmp_ev: Implement fd callback 
> and read data"):
> > First step into taking care of the input from QEMU's QMP socket. For
> > now, we read data and store them in buffers.
> 
> How big is this data ?  Is all this business with a linked list of
> buffers really necessary ?

The alternative is realloc. I don't know how big the data is going to
be. I don't want to speculate.

But right now, QMP_RECEIVE_BUFFER_SIZE is set to 4k, I don't think we
would need more than that, but I think the code need to be prepared to
receive more.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.