[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: correctly set nonlazy_xstate_used when loading full state

On Tue, Jun 26, 2018 at 02:11:32AM -0600, Jan Beulich wrote:
> >>> On 26.06.18 at 09:57, <wei.liu2@xxxxxxxxxx> wrote:
> > On Tue, Jun 26, 2018 at 01:47:12AM -0600, Jan Beulich wrote:
> >> In this case, just like xcr0_accum, nonlazy_xstate_used should always be
> >> set to the intended new value, rather than possibly leaving the flag set
> >> from a prior state load.
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > Why? Looking at the code it is in fact used as a boolean.
> Its boolean nature is irrelevant. The question is whether fully new state
> is loaded (in which case the flag should be set according to this state,
> without regard to the prior value of the flag) vs ...

I see. I misunderstood your intent.

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.