Re: [Xen-devel] [PATCH] gnttab: silence table expansion message

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf
> Of Andrew Cooper
> Sent: 26 June 2018 12:15
> To: Jan Beulich <JBeulich@xxxxxxxx>; xen-devel <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu
> <wei.liu2@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; Tim
> (Xen.org) <tim@xxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Julien Grall
> <julien.grall@xxxxxxx>
> Subject: Re: [Xen-devel] [PATCH] gnttab: silence table expansion message
> 
> On 26/06/18 08:22, Jan Beulich wrote:
> > This currently shows up for basically every domain, when originally it
> > was logged only when going beyond the default table size. Restore that
> > behavior.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > --- a/xen/common/grant_table.c
> > +++ b/xen/common/grant_table.c
> > @@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
> >          req_nr_frames = INITIAL_NR_GRANT_FRAMES;
> >      ASSERT(req_nr_frames <= gt->max_grant_frames);
> >
> > -    gdprintk(XENLOG_INFO,
> > -            "Expanding d%d grant table from %u to %u frames\n",
> > -            d->domain_id, nr_grant_frames(gt), req_nr_frames);
> > +    if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
> > +        gdprintk(XENLOG_INFO,
> > +                 "Expanding d%d grant table from %u to %u frames\n",
> > +                 d->domain_id, nr_grant_frames(gt), req_nr_frames);
> 
> This has been on my todo list for a while, but I'd go one stage further
> and delete it fully.
> 
> Domains either never trigger it, or expand to max.  It doesn't provide
> any useful information at all.

That's not entirely true. Windows PV drivers expand the grant table on demand, 
not straight to max. Having said that, they do their own logging so the extra 
noise from Xen is not useful.

  Paul

> 
> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel