[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

On 06/06/18 11:06, Julien Grall wrote:

On 05/06/18 19:26, Lars Kurth wrote:

On 05/06/2018, 19:15, "Juergen Gross" <jgross@xxxxxxxx> wrote:

     On 05/06/18 18:39, Julien Grall wrote:
     > The option -f of scripts/get_maintainers.pl will return the maintainers      > of a given file, *not* the list of maintainers if the file was a patch.
     > The output expected of add_maintainers is the latter, so drop the option
     > -f.
     > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
     Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Lars.kurth@xxxxxxxxxx

This change in behaviour was mistakenly introduced in one of the later revisions (can't recall which), when we refactored the call to get_maintainers.pl

Thank you! Other than that the script is working quite well and save me time to add all the CCs.

I will commit the patch once we branched.

I was about to commit but I forgot that I would need a ack from someone in "THE REST".

Can I get one from either, Andrew, George, Ian, Jan, Tim, Wei, Stefano?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.