[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

The option -f of scripts/get_maintainers.pl will return the maintainers
of a given file, *not* the list of maintainers if the file was a patch.

The output expected of add_maintainers is the latter, so drop the option

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

    This patch is candidate for Xen 4.11. Without it add_maintainers.pl
    will not return the correct maintainers. IHMO, it should be fixed
    ASAP to avoid promoting a broken scripts.
 scripts/add_maintainers.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl
index 99e4724112..09e9f6609f 100755
--- a/scripts/add_maintainers.pl
+++ b/scripts/add_maintainers.pl
@@ -420,7 +420,7 @@ sub ismailinglist ($) {
 sub getmaintainers ($$$) {
     my ($file, $rto, $rcc) = @_;
     my $fh;
-    open($fh, "-|", $get_maintainer, @get_maintainer_args, '-f', $file)
+    open($fh, "-|", $get_maintainer, @get_maintainer_args, $file)
         or die "Failed to open '$get_maintainer'\n";
     while(my $line = <$fh>) {
         chomp $line;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.