Re: [Xen-devel] [PATCH v5 08/10] arm: add ALL, QEMU, Rcar3 and MPSoC configs

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 04/06/18 18:24, Stefano Stabellini wrote:
> Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3,
> MPSOC and ALL. They enable the required options for their hardware
> platform. ALL enables all available platforms and it's the default. It
> doesn't automatically select any of the related drivers, otherwise they
> cannot be disabled. ALL is implemented by selecting hidden options
> corresponding to QEMU, MPSOC and RCAR3.
>
> In the case of the MPSOC that has a platform file under
> arch/arm/platforms/, build the file if MPSOC.
>
> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: artem_mygaiev@xxxxxxxx
> CC: volodymyr_babchuk@xxxxxxxx
>
> ---
> Changes in v5:
> - turn platform support into a choice
> - add ALL
>
> Changes in v4:
> - fix GICv3/GICV3
> - default y to all options
> - build xilinx-zynqmp if MPSOC
> ---
>   xen/arch/arm/Kconfig            |  2 ++
>   xen/arch/arm/platforms/Kconfig  | 54 +++++++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/platforms/Makefile |  2 +-
>   3 files changed, 57 insertions(+), 1 deletion(-)
>   create mode 100644 xen/arch/arm/platforms/Kconfig
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 2b87111..75cacfb 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -213,6 +213,8 @@ config ARM64_HARDEN_BRANCH_PREDICTOR
>   config ARM32_HARDEN_BRANCH_PREDICTOR
>       def_bool y if ARM_32 && HARDEN_BRANCH_PREDICTOR
>   
> +source "arch/arm/platforms/Kconfig"
> +
>   source "common/Kconfig"
>   
>   source "drivers/Kconfig"
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> new file mode 100644
> index 0000000..8b3bedd
> --- /dev/null
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -0,0 +1,54 @@
> +choice
> +       prompt "Platform Support"
> +       default ALL
> +       ---help---
> +       Choose which hardware platform to enable in Xen.
> +
> +       If unsure, choose ALL.
> +
> +config ALL
> +       bool "All Platforms"
> +       select MPSOC_PLATFORM
> +       select QEMU_PLATFORM
> +       select RCAR3_PLATFORM
> +       ---help---
> +       Enable support for all available hardware platforms.
This is slightly untrue. A user would be able to disable GICV3 for 
instance. So hardware such as QEMU would not be supported.
So I think you want to clarify the description with something similar to 
what you wrote in the commit message.
The rest looks good to me.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel