[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.11] x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Tue, 5 Jun 2018 03:02:10 +0000
  • Accept-language: en-US
  • Cc: Juergen Gross <jgross@xxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Tue, 05 Jun 2018 03:02:28 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version:
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHT+Pjy2Zy66t1uz0O4sLLr1GMZlaRRAKHw
  • Thread-topic: [PATCH for-4.11] x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()

> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Friday, June 1, 2018 12:03 AM
> This is essentially a "take 2" of c/s 82540b66ce "x86/VT-x: Fix determination
> of EFER.LMA in vmcs_dump_vcpu()" because in hindight, that change was
> more
> problematic than useful.
> The original reason was to fix the logic for determining when not to print
> the
> PDPTE pointers.  However, mutating the efer variable (particularly LME and
> LMA) before printing it interferes with diagnosing vmentry failures.
> Instead of modifying efer, change the PDPTE conditional to use
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.