Re: [Xen-devel] [PATCH for-4.11] x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.05.18 at 18:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> This is essentially a "take 2" of c/s 82540b66ce "x86/VT-x: Fix determination
> of EFER.LMA in vmcs_dump_vcpu()" because in hindight, that change was more
> problematic than useful.
> 
> The original reason was to fix the logic for determining when not to print the
> PDPTE pointers.  However, mutating the efer variable (particularly LME and
> LMA) before printing it interferes with diagnosing vmentry failures.

I was wondering then, but not enough to ask back.

> Instead of modifying efer, change the PDPTE conditional to use
> VM_ENTRY_IA32E_MODE.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel