Re: [Xen-devel] [PATCH v4] x86/cpu: Add supports for zhaoxin x86 platform

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.05.18 at 03:37, <Davidwang@xxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/intel_cacheinfo.c
> +++ b/xen/arch/x86/cpu/intel_cacheinfo.c
> @@ -176,7 +176,9 @@ unsigned int init_intel_cacheinfo(struct cpuinfo_x86 *c)
>        * Don't use cpuid2 if cpuid4 is supported. For P4, we use cpuid2 for
>        * trace cache
>        */
> -     if ((num_cache_leaves == 0 || c->x86 == 15) && c->cpuid_level > 1) {
> +     if ( (num_cache_leaves == 0 || c->x86 == 15) && c->cpuid_level > 1 &&
> +             c->x86_vendor != X86_VENDOR_SHANGHAI )

The indentation here is _still_ wrong (and there are stray spaces), but I'll try
to remember fixing this up when committing (after 4.11 was branched off),
i.e. with that fixed
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Also once again - in the future, after the 1st --- separator please add an
overview of what has changed from the previous version.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel