Re: [Xen-devel] [PATCH] xl/libxl: add pvcalls support

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Stefano Stabellini writes ("[PATCH] xl/libxl: add pvcalls support"):
> Add pvcalls support to libxl and xl. Create the appropriate pvcalls
> entries in xenstore.
...
> +#### ~/device/pvcalls/$DEVID/* []
> +
> +Paravirtualized POSIX function calls frontend. Described by
> +[docs/misc/pvcalls.markdown][PVCALLS]

It's not entirely clear what the semantics are if multiple pvcalls
devices are provided.  Which is the guest expected to use ?

Perhaps the doc should state some convention, if there is one.  I hope
there is such a convention ($DEVID usually 0 maybe?)

> +    for (i = 0; i < d_config->num_pvcallss; i++)

The name `pvcallss' is clumsy.  But I'm not sure I have a much better
suggestion.

One idea might be to rename your whole thing `pvrpc' since it's a
general RPC scheme, more or less.  Except that I don't want to come in
now and say you should rename it.  And also most rpc systems have an
idl language and you have ad hoc binary structs.

Have you considered calling this `pvcallsifs' ?  Where `if' is
`intrerface' ?  Or something ?

Anyway, I would like you to think about this and answer my questions
but I don't think it's a blocker. 

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel