[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] get_maintainers.pl: Avoid THE_REST when files are added or removed

Hi Jan,

On Thu, Feb 22, 2018 at 02:45:48AM -0700, Jan Beulich wrote:
> Oh, I see - it's the file name collection code you change, not the
> consuming side, I'm sorry for the noise. However, isn't
> omitting the leading / a potential problem then?

The leading / is stripped away several lines before this..

> While it's not
> very likely for us to gain ./dev/null, it's also not entirely impossible.

True and this change does mean that get_maintainer.pl would fail to
recognise such a patch as a patch..(just tried)

> Furthermore, shouldn't you move the setting of $lastfile into
> the conditional as well?

Let me send a second version....


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.