[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] get_maintainers.pl: Avoid THE_REST when files are added or removed

Hi Jan,

On Thu, Feb 22, 2018 at 02:16:23AM -0700, Jan Beulich wrote:
> From: Jan Beulich <JBeulich@xxxxxxxx>
> Subject: Re: [PATCH] get_maintainers.pl: Avoid THE_REST when files are
>  added or removed
> >>> On 22.02.18 at 10:09, <Alan.Robinson@xxxxxxxxxxxxxx> wrote:
> > When files are added or removed /dev/null is used as a place
> > holder name in the patch for the absent file.  Don't try and
> > find a MAINTAINER for this place holder, it only ever flags
> > and then spams THE REST.
> When a file is added, it falls under THE REST maintainership unless
> there's a pattern already in place covering the file, or a new entry
> is being added at the same time. When a file is removed, whoever
> was its maintainer should be Cc-ed. So perhaps it's rather the
> /dev/null placeholder use that's wrong?
Exactly - that what this patch tries to do...

get_maintainers.pl collects filename from the '+++' and '---' lines. A 
normal (not add/remove) patch looks like this:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 0ce2d367fa..277ba17a67 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl

An add/delete patch looks like this:

diff --git a/xen/common/cpupool.c b/xen/common/cpupool.c
deleted file mode 100644
index 999839444e..0000000000
--- a/xen/common/cpupool.c
+++ /dev/null

Here get_maintainers.pl finds two files, change _just_ ignores the

> Also, please send patches _to_ the list, _cc_-ing individuals as
> needed.
Ahh..sorry about that


Alan Robinson
Enterprise Platform Services, Germany

Mies-van-der-Rohe-Str. 8, 80807 Muenchen, Deutschland
Tel.: +49 (89) 62060 3927
Mob.: +49 (172) 8512843
E-Mail: Alan.Robinson@xxxxxxxxxxxxxx
Web: http://www.fujitsu.com/de/

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.