Re: [Xen-devel] [PATCH v2] VT-d: use two 32-bit writes to update DMAR fault address registers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Oct 11, 2017 at 05:27:05AM -0600, Jan Beulich wrote:
> >>> On 11.10.17 at 05:03, <haozhong.zhang@xxxxxxxxx> wrote:
> > --- a/xen/drivers/passthrough/vtd/iommu.c
> > +++ b/xen/drivers/passthrough/vtd/iommu.c
> > @@ -1105,7 +1105,13 @@ static void dma_msi_set_affinity(struct irq_desc 
> > *desc, const cpumask_t *mask)
> >  
> >      spin_lock_irqsave(&iommu->register_lock, flags);
> >      dmar_writel(iommu->reg, DMAR_FEDATA_REG, msg.data);
> > -    dmar_writeq(iommu->reg, DMAR_FEADDR_REG, msg.address);
> > +    dmar_writel(iommu->reg, DMAR_FEADDR_REG, msg.address_lo);
> > +    /*
> > +     * When x2APIC is not enabled, DMAR_FEUADDR_REG is reserved and
> > +     * it's not necessary to update it.
> > +     */
> > +    if (x2apic_enabled)
> 
> I'm pretty sure it was pointed out before that the style here is
> wrong (missing spaces). That's easy to fix while committing, but
> anyway.

It seems like this was not applied. Can someone fix the style and
apply it?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel