Re: [Xen-devel] [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jan 29, 2018 at 09:45:35AM -0700, Jan Beulich wrote:
> >>> On 29.01.18 at 13:26, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/asm_defns.h
> > +++ b/xen/include/asm-x86/asm_defns.h
> > @@ -14,6 +14,9 @@
> >  #include <asm/alternative.h>
> >  
> >  #ifdef __ASSEMBLY__
> > +# ifndef CONFIG_INDIRECT_THUNK
> > +#  define CONFIG_INDIRECT_THUNK 0
> > +# endif
> 
> Why not an assembler equate? It is common to use "#ifdef CONFIG_..."
> if wanting to test for an enabled config option, and such a check
> will go wrong with a C level define.

I haven't used an equate because that doesn't work well with clang,
because clang keeps equates between asm()-s, but not .macro-s.

Anyway, since there seems to be comments in other patches that will
prevent from switching to clang's integrated assembler I guess it's
not worth arguing over this.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel