Re: [Xen-devel] [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.01.18 at 13:26, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/asm_defns.h
> +++ b/xen/include/asm-x86/asm_defns.h
> @@ -14,6 +14,9 @@
>  #include <asm/alternative.h>
>  
>  #ifdef __ASSEMBLY__
> +# ifndef CONFIG_INDIRECT_THUNK
> +#  define CONFIG_INDIRECT_THUNK 0
> +# endif

Why not an assembler equate? It is common to use "#ifdef CONFIG_..."
if wanting to test for an enabled config option, and such a check
will go wrong with a C level define.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel