[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3] x86/hvm: Improvements to external users of decode_register()

>>> On 26.01.18 at 14:16, <andrew.cooper3@xxxxxxxxxx> wrote:
> * Rename to decode_gpr() to be more specific as to its purpose
> * Drop the highbyte encoding handling, as users care, and it unlikely that

"... as users don't care, and it's ..." or "... as no users care, and it's

> @@ -601,14 +609,23 @@ int x86_emulate_wrapper(
>  #define x86_emulate x86_emulate_wrapper
>  #endif
> +/* Map GPRs by ModRM encoding to their offset within struct cpu_user_regs. */
> +extern const uint8_t cpu_user_regs_gpr_offsets[X86_NR_GPRS];

Okay, this explains why you don't want this array inside the

With the description suitably corrected
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.