Re: [Xen-devel] [PATCH 2/3] x86/hvm: Improvements to external users of decode_register()

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Friday, January 26, 2018 9:17 PM
> 
>  * Rename to decode_gpr() to be more specific as to its purpose
>  * Drop the highbyte encoding handling, as users care, and it unlikely that
>    future users would care.
>  * Change to a static inline, returning an unsigned long pointer.
> 
> Doing so highlights that the "invalid gpr" paths in hvm_mov_{to,from}_cr()
> were actually unreachable.  All callers already passed in-range gprs, which
> would have hit a BUG() previously.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel