Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

[John Thomson <git@xxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, 26 Jan 2018, at 23:16, Christian Lindig wrote:
> using the -unsafe-string option (introduced in OCaml 4.02) to keep 
> strings mutable to avoid code changes is not going to work in the long 
> run.

Okay,
NAK my unsafe-string patch.

On 26. Jan 2018, at 09:09, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
> The patch is at
> https://src.fedoraproject.org/rpms/xen/blob/master/f/xen.ocaml.safe-strings.patch
> with the related Fedora bug at
> https://bugzilla.redhat.com/show_bug.cgi?id=1526703

The safe-string patch is the correct way to fix this problem.
Get that patch signed off, submitted and reviewed in another thread?
with a bump to 4.02.0 in tools/configure.ac
AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.3], [
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/configure.ac;h=d1a3a78d87ce2f077e551c6ee039caad4ad2edc1;hb=refs/heads/staging#l297
The patch author agreed to have the patch upstreamed on the Fedora bug report.
How should this then be signed off and attributed?


I do not know if caml-stubdom uses any of these files, but it seems to use 
ocaml-3.11.0?
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=stubdom/configure;h=a7a0c0915440b7b351a7adf4f40c8f9ee8e739ef;hb=refs/heads/staging#l3534

Cheers,
--
  John Thomson

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel