[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

> On 26. Jan 2018, at 12:00, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>> Reviewed-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
> Taking the above into consideration, does this tag still stand?

Thanks for the clarification. My tag still stands as the code in the patch is 
IMHO fine. 

Regarding Andrew’s comment: the bytes type was introduced in OCaml 4.02 - this 
makes the patch not compatible with OCaml 3.09.3. I still think that using the 
-unsafe-string option (introduced in OCaml 4.02) to keep strings mutable to 
avoid code changes is not going to work in the long run. The current OCaml 
version is 4.06.

— Christian 
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.