Re: [Xen-devel] [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Manish,

On 16/01/18 15:42, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> From: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
>
> Add a config option to enable VGIC Errata Code in Xen. Platforms which do not
> have this errta can compile out this feature.
s/errta/errata/

> Signed-off-by: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
> ---
>   xen/arch/arm/Kconfig | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index f58019d6ed..2966e3a3d3 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -59,6 +59,15 @@ config SBSA_VUART_CONSOLE
>   
>   endmenu
>   
> +menu "Errata Workarounds"
> +       depends on ARM_64
I would much prefer to see the memu "ARM errata workaround via..." 
renamed to "Errata Workarounds". So we have only one menu with all 
workarounds.
> +
> +config VGIC_ERRATA
> +       bool "Handler code for emulation of Group0/1 vGIC registers for VGC 
> Errata"
The title does not help the user to know when to select this option or not.

It looks like to me you want to do something similar to commit 
690a341577f9 "arm64: Add workaround for Cavium Thunder erratum 30115" in 
Linux where the config is called CAVIUM_ERRATA_30115 and a proper 
description explaining the platform affected.
> +       depends on ARM_64
I think this should depend on HAS_GICV3.

> +
> +endmenu
> +
>   menu "ARM errata workaround via the alternative framework"
>         depends on HAS_ALTERNATIVE
>   
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel