Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.01.18 at 16:41, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 12/01/18 11:23, Jan Beulich wrote:
>> Even it you make .init.data its own section again, some
>> garbage will remain (mainly due to the trampoline data).
> 
> That is far easier to spot an isolate, because it is tiny and reasonably
> obviously bounded.

Well, I've pointed out where the easy to spot bounding is:

>>  If you
>> care to use tools to find certain patterns in .init, simply discard
>> everything following _einittext before giving the tool a go. IOW I

^^^

>> would much prefer for things to be left as they are.
> 
> No.  We should not be deliberately corrupting the binary to work around
> a theoretical runtime issue for which there is a perfectly fine runtime
> solution.  This is the real hack.

Putting all init-time code and data in a single section is a perfectly
valid thing to do imo. We don't care about permissions at that
point in time, so the resulting RWX section is quite fine (and has a
name much better suitable for a PE image). Otherwise the fact
that we merge r/o and r/w init time data into a single section
would need to be called a hack, too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel