[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

>>> On 11.01.18 at 15:17, <andrew.cooper3@xxxxxxxxxx> wrote:
> c/s 1308f0170c merged .init.text and .init.data, because EFI might properly
> write-protect r/o sections.
> However, this change makes xen-syms unusable for disassembly analysis.  In
> particular, searching for indirect branches as part of the SP2/Spectre
> mitigation series.
> Revert the relevent bits of 1308f0170c and instead modify the EFI relocation
> code to disable CR0.WP, which is how we deal with relocations in r/o mappings
> elsewhere.

Doing so is a hack, and I dislike spreading hacks without real need.
What's wrong with there being some garbage in the disassembly
of .init? Even it you make .init.data its own section again, some
garbage will remain (mainly due to the trampoline data). If you
care to use tools to find certain patterns in .init, simply discard
everything following _einittext before giving the tool a go. IOW I
would much prefer for things to be left as they are.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.