Re: [Xen-devel] [PATCH for-4.9 4/4] xen/arm: Properly map the FDT in the boot page table

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 19/04/17 22:56, Stefano Stabellini wrote:
> On Wed, 19 Apr 2017, Julien Grall wrote:
> > On 19/04/2017 22:01, Stefano Stabellini wrote:
> > > On Wed, 19 Apr 2017, Julien Grall wrote:
> > > > @@ -113,12 +113,12 @@
> > > >  #define FIXMAP_ADDR(n)        (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE)
> > > >
> > > >  #define BOOT_FDT_VIRT_START    _AT(vaddr_t,0x00600000)
> > > > -#define BOOT_FDT_SLOT_SIZE     MB(2)
> > > > +#define BOOT_FDT_SLOT_SIZE     MB(4)
> > > >  #define BOOT_FDT_VIRT_END      (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE)
> > > >
> > > > -#define BOOT_RELOC_VIRT_START  _AT(vaddr_t,0x00800000)
> > > > +#define BOOT_RELOC_VIRT_START  _AT(vaddr_t,0x00a00000)
> > > Wouldn't it be better to define it as BOOT_FDT_VIRT_END?
> > It is kind of not really related to this patch and how we handle all the
> > region in config.h today. So if we define in term of *_END this one, then we
> > need to do it for everyone.
> Fair enough
I will prepare a patch for that and send it later on.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel