[Xen-devel] [PATCH v6 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

Hi all,

We plan to bring a new PSR (Platform Shared Resource) feature called
Intel L2 Cache Allocation Technology (L2 CAT) to Xen.

Besides the L2 CAT implementaion, we refactor the psr.c to make it more
flexible to add new features and fulfill the principle, open for extension
but closed for modification. We abstract the general operations of all
features and encapsulate them into a structure. Then, the development
of new feature is simple to mainly implement these callback functions.

The patch set can be found at:
https://github.com/yisun-git/xen_l2_cat_v6.git l2_cat_v6-1

v6:
- patch 1:
    - write a new feature document to cover L3 CAT/CDP and L2 CAT.
    - adjust 'Terminology' position in document.
    - fix wordings.
    - add SDM chapter title in commit message.
    - add more explanations.
- patch 3:
    - modify commit message to point out patches to refer to understand details.
    - fix wording.
    - add comments to explain 'feat_mask'.
- patch 4:
    - use 'struct cpuid_leaf' in x86_emulate.h.
    - move cpuid_{,count}_leaf() helpers from cpuid.c to processor.h for
      external user and pass the compilation.
    - fix comments to make them clearer.
    - use __clear_bit().
    - call ASSERT() before __set_bit().
    - adjust printk() position.
- patch 5:
    - change 'PSR_ASSOC_REG_POS' to 'PSR_ASSOC_REG_SHIFT'.
- patch 6:
    - adjust '{' position for switch.
    - define 'PSR_SOCKET_UNKNOWN = 0xFFFF' in 'enum psr_feat_type'.
    - use 'ERANGE' when socket id exceeds the range.
    - adjust value postion of macros.
- patch 7:
    - modify commit message to make it clearer.
    - remove one extra space in code.
    - write a helper function to move get info and get val functions into
      it. Because most codes of 'get_info' and 'get_val' are same.
- patch 9:
    - change 'assemble_val_array' to 'combine_val_array'.
    - check return value of 'get_old_val'.
    - replace some 'EINVAL' to 'ENOSPC'.
- patch 22:
    - check if input level is correct.
- patch 23:
    - rename 'psr-cat-cbm-set' to 'psr-cat-set' per Kevin's comment.
    - return 'EXIT_FAILURE' for error case.
    - print error info when input level is wrong.

Yi Sun (24):
  docs: create Cache Allocation Technology (CAT) and Code and Data
    Prioritization (CDP) feature document
  x86: refactor psr: remove L3 CAT/CDP codes.
  x86: refactor psr: implement main data structures.
  x86: refactor psr: implement CPU init and free flow.
  x86: refactor psr: implement Domain init/free and schedule flows.
  x86: refactor psr: implement get hw info flow.
  x86: refactor psr: implement get value flow.
  x86: refactor psr: set value: implement framework.
  x86: refactor psr: set value: assemble features value array.
  x86: refactor psr: set value: implement cos finding flow.
  x86: refactor psr: set value: implement cos id picking flow.
  x86: refactor psr: set value: implement write msr flow.
  x86: refactor psr: implement CPU init and free flow for CDP.
  x86: refactor psr: implement get hw info flow for CDP.
  x86: refactor psr: implement get value flow for CDP.
  x86: refactor psr: implement set value callback functions for CDP.
  x86: L2 CAT: implement CPU init and free flow.
  x86: L2 CAT: implement get hw info flow.
  x86: L2 CAT: implement get value flow.
  x86: L2 CAT: implement set value flow.
  tools: L2 CAT: support get HW info for L2 CAT.
  tools: L2 CAT: support show cbm for L2 CAT.
  tools: L2 CAT: support set cbm for L2 CAT.
  docs: add L2 CAT description in docs.

 docs/features/intel_psr_cat_cdp.pandoc |  453 +++++++++
 docs/man/xl.pod.1.in                   |   25 +-
 docs/misc/xl-psr.markdown              |   10 +-
 tools/libxc/include/xenctrl.h          |    7 +-
 tools/libxc/xc_psr.c                   |   45 +-
 tools/libxl/libxl.h                    |    9 +
 tools/libxl/libxl_psr.c                |   19 +-
 tools/libxl/libxl_types.idl            |    1 +
 tools/libxl/xl_cmdimpl.c               |  169 +++-
 tools/libxl/xl_cmdtable.c              |    6 +-
 xen/arch/x86/cpuid.c                   |    6 -
 xen/arch/x86/domctl.c                  |   49 +-
 xen/arch/x86/psr.c                     | 1608 ++++++++++++++++++++++++++------
 xen/arch/x86/sysctl.c                  |   45 +-
 xen/include/asm-x86/msr-index.h        |    1 +
 xen/include/asm-x86/processor.h        |    7 +
 xen/include/asm-x86/psr.h              |   29 +-
 xen/include/public/domctl.h            |    2 +
 xen/include/public/sysctl.h            |    6 +
 19 files changed, 2089 insertions(+), 408 deletions(-)
 create mode 100644 docs/features/intel_psr_cat_cdp.pandoc

-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel