Re: [Xen-devel] [PATCH] libxl: don't segfault when creating domain with invalid pvusb device

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Juergen Gross writes ("[PATCH] libxl: don't segfault when creating domain with 
invalid pvusb device"):
> Creating a domain with an invalid controller specification for a pvusb
> device will currently segfault.
> 
> Avoid this by bailing out early in case of a mandatory xenstore path
> not existing.

This should be done by adding a test of tmp for NULL.  libxl__xs_read
does no logging so is not really an improvement.

If you felt like inventing libxl__xs_read_must or something (maybe Wei
has a suggestion for a better name) that calls ENOENT a failure
instead, I'd be happy with that.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel