Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into 
non-GPL binaries"):
> On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote:
> > +links="ABCD"
> > +
> > +for i in $(seq 0 3)
> > +do
> > +    link=${links:$i:1}
> 
> This is not portable.
> 
> Use following instead:
> 
> links="A B C D"
> 
> set $links
> for link in $@

What's wrong with

  links="A B C D"

  for link in $links; do
    ....

?

(To my surprise I discover that there are only marginal dependencies
on bash already in xen.git, so we should probably avoid adding a new
dependency on bash.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel