Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote:
> diff --git a/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh 
> b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh
> new file mode 100755
> index 0000000..28a0dd7
> --- /dev/null
> +++ b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh
> @@ -0,0 +1,116 @@

#!/bin/sh ?

> +# This program is free software; you can redistribute it and/or modify it
> +# under the terms and conditions of the GNU General Public License,
> +# version 2, as published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope it will be useful, but WITHOUT
> +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> +# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> +# more details.
> +#
> +# You should have received a copy of the GNU General Public License along 
> with
> +# this program; If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +cat <<'EndOfASL'
> +    /* Beginning of GPL-only code */
> +
> +    /* _S3 and _S4 are in separate SSDTs */
> +    Name (\_S5, Package (0x04) {
> +        0x00,  /* PM1a_CNT.SLP_TYP */
> +        0x00,  /* PM1b_CNT.SLP_TYP */
> +        0x00,  /* reserved */
> +        0x00   /* reserved */
> +    })
> +    Name(PICD, 0)
> +    Method(_PIC, 1) {
> +        Store(Arg0, PICD)
> +    }
> +EndOfASL
> +
> +# PCI-ISA link definitions
> +# BUFA: List of ISA IRQs available for linking to PCI INTx.
> +# BUFB: IRQ descriptor for returning from link-device _CRS methods.
> +cat <<'EndOfASL'
> +    Scope ( \_SB.PCI0 )  {
> +        Name ( BUFA, ResourceTemplate() { IRQ(Level, ActiveLow, Shared) { 5, 
> 10, 11 } } )
> +        Name ( BUFB, Buffer() { 0x23, 0x00, 0x00, 0x18, 0x79, 0 } )
> +        CreateWordField ( BUFB, 0x01, IRQV )
> +EndOfASL
> +
> +links="ABCD"
> +
> +for i in $(seq 0 3)
> +do
> +    link=${links:$i:1}

This is not portable.

Use following instead:

links="A B C D"

set $links
for link in $@
do
   ...
done

See http://pubs.opengroup.org/onlinepubs/009696799/utilities/set.html

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel