[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 13/19] acpi: Makefile should better tolerate interrupts
On 09/09/2016 11:20 AM, Jan Beulich wrote: >>>> On 09.09.16 at 15:56, <boris.ostrovsky@xxxxxxxxxx> wrote: >> On 09/09/2016 09:29 AM, Jan Beulich wrote: >>>>>> On 09.09.16 at 15:07, <boris.ostrovsky@xxxxxxxxxx> wrote: >>>> On 09/09/2016 04:03 AM, Jan Beulich wrote: >>>>>>>> On 08.09.16 at 20:51, <boris.ostrovsky@xxxxxxxxxx> wrote: >>>>>> On 09/08/2016 10:15 AM, Jan Beulich wrote: >>>>>>>>>> On 07.09.16 at 20:59, <boris.ostrovsky@xxxxxxxxxx> wrote: >>>>>>>> vpath iasl $(PATH) >>>>>>>> all: $(C_SRC) $(H_SRC) >>>>>>>> + rm -fr $(TDIR) >>>>>>> And how is the temporary directory going to get cleaned up when >>>>>>> interrupting make? I think you really should use a subdirectory >>>>>>> underneath the build directory, which then can stay there until >>>>>>> "make clean". And then you can also use mv instead of cp below, >>>>>>> or even move-if-changed. >>>>>> The reason I am doing this in /tmp and use tmp_XXXXX as template is >>>>>> because I found that at least one old versions of iasl has a bug where >>>>>> it can't process path that has a '.' in it. It drops anything after the >>>>>> dot, presumably because it thinks it's file suffix. >>>>> That . is a leading one, as in ./path/file.ext? If so, why can't this be >>>>> made path/file.ext? The leading ./ shouldn't be necessary after all. >>>> No, not a leading one. Inside a name: >>>> >>>> Expected: >>>> >>>> [root@ovs104 libacpi]# mkdir -p /tmp/root/xen.git >>>> [root@ovs104 libacpi]# iasl -vs -p /tmp/root/xen.git/dsdt_anycpu -tc >>> Then my suggestion of using relative paths would still help? >> Apparently it doesn't like any dots: >> >> [root@ovs104 /]# mkdir -p /tmp/root/foo >> [root@ovs104 /]# mkdir -p /tmp/root/bar >> [root@ovs104 /]# cd /tmp/root/foo/ >> [root@ovs104 foo]# ls -aR /tmp/root/ >> /tmp/root/: >> . .. bar foo >> >> /tmp/root/bar: >> . .. >> >> /tmp/root/foo: >> . .. >> [root@ovs104 foo]# ~/iasl.f12 -vs -p "../bar/dsdt_anycpu" -tc > Why would you need to use ../ ? Didn't you ask to test with a relative path? (Not this this is needed anymore, now that Ian suggested a solution). -boris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |