Re: [Xen-devel] [PATCH v3 13/19] acpi: Makefile should better tolerate interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.09.16 at 15:07, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 09/09/2016 04:03 AM, Jan Beulich wrote:
>>>>> On 08.09.16 at 20:51, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> On 09/08/2016 10:15 AM, Jan Beulich wrote:
>>>>>>> On 07.09.16 at 20:59, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>>>>  vpath iasl $(PATH)
>>>>>  all: $(C_SRC) $(H_SRC)
>>>>> + rm -fr $(TDIR)
>>>> And how is the temporary directory going to get cleaned up when
>>>> interrupting make? I think you really should use a subdirectory
>>>> underneath the build directory, which then can stay there until
>>>> "make clean". And then you can also use mv instead of cp below,
>>>> or even move-if-changed.
>>> The reason I am doing this in /tmp and use tmp_XXXXX as template is
>>> because I found that at least one old versions of iasl has a bug where
>>> it can't process path that has a '.' in it. It drops anything after the
>>> dot, presumably because it thinks it's file suffix.
>> That . is a leading one, as in ./path/file.ext? If so, why can't this be
>> made path/file.ext? The leading ./ shouldn't be necessary after all.
> 
> No, not a leading one. Inside a name:
> 
> Expected:
> 
> [root@ovs104 libacpi]# mkdir -p /tmp/root/xen.git
> [root@ovs104 libacpi]# iasl -vs -p /tmp/root/xen.git/dsdt_anycpu -tc

Then my suggestion of using relative paths would still help?

>>  (And btw., thinking about it again I don't see the need for a
>> subdirectory. We have ample room to name the intermediate files
>> suitably without causing any name collision.)
> 
> That, in fact, is what I initially had --- I just added an extra temp
> suffix to intermediate files during a build. And right before sending
> the series I figured I'd give it a spin on our build server. Big mistake!

Big mistake? You leave me curious, but unable guess.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel