Re: [Xen-devel] [PATCH v2 13/23] acpi/hvmloader: Include file/paths adjustments

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 08/10/2016 09:30 AM, Jan Beulich wrote:

>> +#ifndef __ACPI_X86_H__
>> +#define __ACPI_X86_H__
>> +
>> +#define IOAPIC_BASE_ADDRESS 0xfec00000
> This will need re-basing - looks like your submission and my commit
> happened at about the same time.

Right, I saw that but this series is based on Anthony's tree so I
couldn't use it yet.

>
>> --- a/tools/firmware/hvmloader/hvmloader.c
>> +++ b/tools/firmware/hvmloader/hvmloader.c
>> @@ -24,8 +24,9 @@
>>  #include "config.h"
>>  #include "pci_regs.h"
>>  #include "apic_regs.h"
>> -#include "acpi/acpi2_0.h"
>> +#include "acpi2_0.h"
> Could you see to pass a suitable string via -D from the Makefile to
> prefix to headers like this one? That would clarify to the reader that
> the file being looked for is not in the current directory. The primary
> other option that I see would be to use <> instead of "", and keep
> the -I in the Makefile. Perhaps that would even be the more natural
> variant.

Yes, I'll see if that (< >) works.

-boris
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel