Re: [Xen-devel] [PATCH v2 13/23] acpi/hvmloader: Include file/paths adjustments

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.16 at 23:06, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/acpi/README
> +++ b/tools/firmware/hvmloader/acpi/README
> @@ -1,11 +1,19 @@
> -ACPI Table for domain firmware
> +ACPI builder for domain firmware
>  
>  
> -INSTALL
> +BUILDING ACPI
>  -----------------
> -Simply make is OK.
> -# make 
> +Users of ACPI builder are expected to provide an include file that defines

s/defines/makes available/ (since a declaration would fully suffice)?

> +the following:
> +* strncpy
> +* printf
> +* NULL
> +* test_bit
> +* offsetof
>  
> +When compiling build.c, the name of this include file should be given to
> +compiler as -DSTDUTILS=\"<filename>\". See tools/firmware/hvmloader/Makefile

Perhaps worthwhile using LIBACPI_STDUTILS to reduce the chance
of a name space conflict?

> +#ifndef __ACPI_X86_H__
> +#define __ACPI_X86_H__
> +
> +#define IOAPIC_BASE_ADDRESS 0xfec00000

This will need re-basing - looks like your submission and my commit
happened at about the same time.

> --- a/tools/firmware/hvmloader/hvmloader.c
> +++ b/tools/firmware/hvmloader/hvmloader.c
> @@ -24,8 +24,9 @@
>  #include "config.h"
>  #include "pci_regs.h"
>  #include "apic_regs.h"
> -#include "acpi/acpi2_0.h"
> +#include "acpi2_0.h"

Could you see to pass a suitable string via -D from the Makefile to
prefix to headers like this one? That would clarify to the reader that
the file being looked for is not in the current directory. The primary
other option that I see would be to use <> instead of "", and keep
the -I in the Makefile. Perhaps that would even be the more natural
variant.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel