Re: [Xen-devel] [PATCH] x86/mmcfg: Fix initalisation of variables in pci_mmcfg_nvidia_mcp55()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/08/16 11:24, Jan Beulich wrote:
>>>> On 03.08.16 at 11:51, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
>> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
>> @@ -182,10 +182,10 @@ static const char __init *pci_mmcfg_nvidia_mcp55(void)
>>      int bus, i;
>>  
>>      static const u32 extcfg_regnum      = 0x90;
>> -    static const u32 extcfg_enable_mask = 1<<31;
>> -    static const u32 extcfg_start_mask  = 0xff<<16;
>> +    static const u32 extcfg_enable_mask = 1u << 31;
> Aiui only this one change is really related to the patch subject; the
> other two I suppose you just alter for consistency? Anyway,
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Indeed.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel