Re: [Xen-devel] [PATCH] x86/mmcfg: Fix initalisation of variables in pci_mmcfg_nvidia_mcp55()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.08.16 at 11:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
> @@ -182,10 +182,10 @@ static const char __init *pci_mmcfg_nvidia_mcp55(void)
>      int bus, i;
>  
>      static const u32 extcfg_regnum      = 0x90;
> -    static const u32 extcfg_enable_mask = 1<<31;
> -    static const u32 extcfg_start_mask  = 0xff<<16;
> +    static const u32 extcfg_enable_mask = 1u << 31;

Aiui only this one change is really related to the patch subject; the
other two I suppose you just alter for consistency? Anyway,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> +    static const u32 extcfg_start_mask  = 0xffu << 16;
>      static const int extcfg_start_shift = 16;
> -    static const u32 extcfg_size_mask   = 0x3<<28;
> +    static const u32 extcfg_size_mask   = 3u << 28;
>      static const int extcfg_size_shift  = 28;
>      static const int extcfg_sizebus[]   = {0xff, 0x7f, 0x3f, 0x1f};
>      static const u32 extcfg_base_mask[] = {0x7ff8, 0x7ffc, 0x7ffe, 0x7fff};
> -- 
> 2.1.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel